Re: [PATCH v5 03/12] PCI: brcmstb: Use common error handling code in brcm_pcie_probe()

From: Florian Fainelli
Date: Thu Aug 01 2024 - 12:41:45 EST


On 7/31/24 15:28, Jim Quinlan wrote:
o Move the clk_prepare_enable() below the resource allocations.
o Move the clk_prepare_enable() out of __brcm_pcie_remove() but
add it to the end of brcm_pcie_remove().
o Add a jump target (clk_disable_unprepare) so that a bit of exception
handling can be better reused at the end of this function implementation.
o Use dev_err_probe() where it makes sense.

Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian