Re: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list

From: Mark Brown
Date: Thu Aug 01 2024 - 15:15:11 EST


On Thu, Aug 01, 2024 at 05:45:49PM +0100, Marc Zyngier wrote:

> Can we please switch all this stuff to symbolic naming instead of
> magic numbers? Given how much effort is going into the "automated
> generation" thing, it is mind-boggling that the tests still rely on
> handcrafted numbers. We just end-up with two different sets of bugs.

> At the moment, the level of confidence I have in this stuff is
> sub-zero.

Yeah, I was wondering why this wasn't using the generated values
especially given that the generated headers are available to tools - I
wasn't sure if this was a deliberate decision to cross check the data
entry or something. I'd certainly be happy to convert, though that does
seem a bit invasive for a fix.

Attachment: signature.asc
Description: PGP signature