Re: [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe

From: Thomas Gleixner
Date: Thu Aug 01 2024 - 16:19:02 EST

Next message: Paweł Owoc: "[PATCH] wifi: ath10k: add channel 177 for 5 GHz band"
Previous message: Gustavo A. R. Silva: "Re: [gustavoars:testing/wfamnae-next20240729-cbc-2 11/18] include/rdma/uverbs_ioctl.h:643:15: error: static assertion failed due to requirement '__builtin_offsetof(struct uverbs_attr_bundle, attrs) == sizeof(struct uverbs_attr_bundle_hdr)': struct member likely outside of struct_group_tagged()"
In reply to: Aruna Ramakrishna: "Re: [PATCH v7 2/5] x86/pkeys: Add helper functions to update PKRU on the sigframe"
Next in thread: Aruna Ramakrishna: "[PATCH v7 1/5] x86/pkeys: Add PKRU as a parameter in signal handling functions"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Aug 01 2024 at 20:14, Aruna Ramakrishna wrote:
>> On Aug 1, 2024, at 1:57 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> On Thu, Aug 01 2024 at 06:51, Aruna Ramakrishna wrote:
>>>
>>> +extern void __user *get_xsave_addr_user(struct xregs_state *xsave, int xfeature_nr);
>>
>> *xsave lacks __user
>>
> Did you get a chance to review the rest of the patchset? If you have any
> additional comments/suggestions, I can batch those fixes into v8.

I did not find anything problematic.

If you spin up a V8 you could polish your changelogs a bit and give them
some structure. They mostly consist of one big lump. See:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#changelog

for some examples.

Thanks,

tglx