Re: [PATCH net-next v2] net: mctp: Consistent peer address handling in ioctl tag allocation
From: Jeremy Kerr
Date: Thu Aug 01 2024 - 20:22:09 EST
Hi Jakub and John,
> On Tue, 30 Jul 2024 16:46:35 +0800 John Wang wrote:
> > When executing ioctl to allocate tags, if the peer address is 0,
> > mctp_alloc_local_tag now replaces it with 0xff. However, during tag
> > dropping, this replacement is not performed, potentially causing
> > the key
> > not to be dropped as expected.
> >
> > Signed-off-by: John Wang <wangzhiqiang02@xxxxxxxxxxxxx>
>
> Looks sane. Jeremy? Matt?
All looks good to me!
Reviewed-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
(John had already discussed the change with us, so no surprises on my
side)
> In netdev we try to review patches within 24-48 hours.
> You have willingly boarded this crazy train.. :)
Yeah we bought express tickets to netdev town! I just saw that there
were nipa warnings on patchwork, so was waiting on a v3. If it's okay
as-is, I'm happy for a merge.
Cheers,
Jeremy