Re: [PATCH] e1000e: use ip_hdrlen() instead of bit shift

From: Moon Yeounsu
Date: Thu Aug 01 2024 - 22:26:16 EST


On Thu, Aug 1, 2024 at 11:06 PM Florian Westphal <fw@xxxxxxxxx> wrote:
> This helper needs skb_network_header being set up correctly, are you
> sure thats the case here? ip pointer is fetched via data + 14 right
> above, so it doesn't look like this would work.
I read it once more carefully, and yes, you are right.
Sorry for wasting your time...
It is my first patch to the netdev subsystem.
So... I was too excited. It's all my fault.
Next time, I'll be careful and deliberate.

Thank you for reviewing.