Re: [PATCH v7 4/5] wifi: brcmfmac: Add optional lpo clock enable support

From: Arend Van Spriel
Date: Fri Aug 02 2024 - 01:38:41 EST


On August 2, 2024 4:57:48 AM Jacobe Zang <jacobe.zang@xxxxxxxxxx> wrote:

WiFi modules often require 32kHz clock to function. Add support to
enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check
to the top of brcmf_of_probe. Change function prototypes from void
to int and add appropriate errno's for return values.

Sorry, but this is moving in the wrong direction. The reason for changing from void to int was to propagate the error up to the bus, ie. PCIe, SDIO, or USB. Anyway, I reworked this patch last night to do just that. Let me send it out to you.

Regards,
Arend

Co-developed-by: Ondrej Jirman <megi@xxxxxx>
Signed-off-by: Ondrej Jirman <megi@xxxxxx>
Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
Change-Id: I21bf9e21b275452369dce1f50c2f092eded6376c
---
.../wireless/broadcom/brcm80211/brcmfmac/of.c | 49 +++++++++++--------
.../wireless/broadcom/brcm80211/brcmfmac/of.h | 4 +-
2 files changed, 31 insertions(+), 22 deletions(-)