Re: [PATCH V3 09/10] bnxt_en: Add TPH support in BNXT driver

[Wei Huang]

On 7/23/24 11:48, Bjorn Helgaas wrote:
> On Wed, Jul 17, 2024 at 03:55:10PM -0500, Wei Huang wrote:
> > From: Manoj Panicker <manoj.panicker2@xxxxxxx>
> >
> > Implement TPH support in Broadcom BNXT device driver by invoking
> > pcie_tph_set_st() function when interrupt affinity is changed.
>
> *and* invoking pcie_tph_set_st() when setting up the IRQ in the first
> place, I guess?
>
> I guess this gives a significant performance benefit?  The series
> includes "pci=nostmode" so the benefit can be quantified, so now I'm
> curious about what you measured :)

Using network benchmarks, three main metrics were measured: network 
latency, network bandwidth, and memory bandwidth saving.

> > +static void bnxt_rtnl_lock_sp(struct bnxt *bp);
> > +static void bnxt_rtnl_unlock_sp(struct bnxt *bp);
>
> These duplicate declarations can't be right, can they?  OK for
> work-in-progress, but it doesn't look like the final solution.

Will fix.