Re: [PATCH] riscv: support KASAN instrumentation of bitops

[Conor Dooley]

On Fri, Aug 02, 2024 at 07:45:38AM +0200, Alexandre Ghiti wrote:
> Hi Qingfang,
> 
> On 02/08/2024 06:05, Qingfang Deng wrote:
> > From: Qingfang Deng <qingfang.deng@xxxxxxxxxxxxxxx>
> > 
> > The arch-specific bitops are not being picked up by the KASAN test
> > suite.
> > 
> > Instrumentation is done via the bitops/instrumented-{atomic,lock}.h
> > headers. They require that arch-specific versions of bitop functions
> > are renamed to arch_*. Do this renaming.
> > 
> > As most comments are identical to the ones in the instrumented headers,
> > remove them.
> > 
> > Signed-off-by: Qingfang Deng <qingfang.deng@xxxxxxxxxxxxxxx>

> Samuel has just posted a similar patch here https://lore.kernel.org/linux-riscv/20240801033725.28816-1-samuel.holland@xxxxxxxxxx/T/#t

Additionally Samuel's patch has the advantage of compiling :)

This one errors with:
include/asm-generic/bitops/instrumented-lock.h:80:16: error: implicit declaration of function 'arch_xor_unlock_is_negative_byte'; did you mean 'xor_unlock_is_negative_byte'? [-Werror=implicit-function-declaration]

Attachment: signature.asc
Description: PGP signature