Re: [PATCH] rust: add `ARef::into_raw`
From: Boqun Feng
Date: Fri Aug 02 2024 - 10:21:10 EST
On Thu, Aug 01, 2024 at 04:45:02PM +0200, Alice Ryhl wrote:
> On Thu, Aug 1, 2024 at 4:17 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> >
> > Add a method for `ARef` that is analogous to `Arc::into_raw`. It is the
> > inverse operation of `ARef::from_raw`, and allows you to convert the
> > `ARef` back into a raw pointer while retaining ownership of the
> > refcount.
> >
> > This new function will be used by [1] for converting the type in an
> > `ARef` using `ARef::from_raw(ARef::into_raw(me).cast())`. The author has
> > also needed the same function for other use-cases in the past, but [1]
> > is the first to go upstream.
> >
> > Link: https://lore.kernel.org/r/20240801-vma-v3-1-db6c1c0afda9@xxxxxxxxxx [1]
> > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>
> Actually I just realized that there's already another use on the list in
> https://lore.kernel.org/all/20240725-alice-file-v8-0-55a2e80deaa8@xxxxxxxxxx/
Yes, I was about to point this out ;-)
I picked this up in rust-dev and rebased file patches onto it for
testing purpose.
In the meanwhile,
Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>
Regards,
Boqun