Re: [PATCH v3] dt-bindings: edac: Add Altera SOCFPGA SDRAM EDAC binding

[Alessandro Zanni]

Thank you for the review.

This patch aims to be a conversion from txt file
"bindings/arm/altera/socfpga-sdram-edac.txt" to this
"bindings/edac/altr,sdram-edac.yaml" file.
That's why I also deleted the txt file in the patch.

Maybe I should have put a different title to make it clearer.

This is the original example in the txt file:
sdramedac {
    compatible = "altr,sdram-edac";
    altr,sdr-syscon = <&sdr>;
    interrupts = <0 39 4>;

and this is my conversion:
> +  - |
> +    memory-controller {
> +      compatible = "altr,sdram-edac";
> +      altr,sdr-syscon = <&sdr>;
> +      interrupts = <0 39 4>;

Sorry for that but, to me, it's not clear what I should convert in
this example to complete the yaml file.

Best regards,
Alessandro


Il giorno ven 2 ago 2024 alle ore 08:54 Krzysztof Kozlowski
<krzk@xxxxxxxxxx> ha scritto:
>
> On 01/08/2024 18:10, Alessandro Zanni wrote:
> > Convert the device tree bindings for the Altera PCIe MSI controller
> >
> > Signed-off-by: Alessandro Zanni <alessandro.zanni87@xxxxxxxxx>
> > ---
> >
>
> Subject: you did not add binding in this patch. Binding was already
> there. You converted one to DT schema.
>
>
> > Notes:
> >     v3: moved yaml file from arm/altera to the edac folder, removed items keys, added general node names
> >
>
> ...
>
> > +
> > +examples:
> > +  - |
> > +    memory-controller {
> > +      compatible = "altr,sdram-edac";
> > +      altr,sdr-syscon = <&sdr>;
> > +      interrupts = <0 39 4>;
>
> No improvements here.
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
> </form letter>
>
>
> Best regards,
> Krzysztof
>