Re: [PATCH V3 04/10] PCI/TPH: Add pci=nostmode to force No ST Mode
From: Bjorn Helgaas
Date: Fri Aug 02 2024 - 13:05:45 EST
On Thu, Aug 01, 2024 at 11:29:22PM -0500, Wei Huang wrote:
> On 7/23/24 17:44, Bjorn Helgaas wrote:
> > > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > > @@ -4656,6 +4656,7 @@
> > > norid [S390] ignore the RID field and force use of
> > > one PCI domain per PCI function
> > > notph [PCIE] Do not use PCIe TPH
> > > + nostmode [PCIE] Force TPH to use No ST Mode
> >
> > Needs a little more context here about what this means. Users won't
> > know where to even look for "No ST Mode" unless they have a copy of
> > the spec.
>
> I can certainly add more description to talk about "No ST Mode". Also, will
> "tph_nostmode" be better than "nostmode" in your opinion?
I don't really care about the parameter name. I think just spelling
these out once, e.g., "PCIe TLP Processing Hints (TPH)" and "No ST
Mode (Steering Tags must be all zeros)" is probably enough context.