Re: [PATCH V3 0/2] uapi: Add support for GENMASK_U128()
From: Yury Norov
Date: Fri Aug 02 2024 - 13:38:32 EST
On Fri, Aug 02, 2024 at 07:00:43AM +0530, Anshuman Khandual wrote:
>
>
> On 8/1/24 20:13, Yury Norov wrote:
> > On Thu, Aug 1, 2024 at 12:16 AM Anshuman Khandual
> > <anshuman.khandual@xxxxxxx> wrote:
> >>
> >> This adds support for GENMASK_U128() and some corresponding tests as well.
> >> GENMASK_U128() generated 128 bit masks will be required later on the arm64
> >> platform for enabling FEAT_SYSREG128 and FEAT_D128 features.
> >>
> >> Because GENMAKS_U128() depends on __int128 data type being supported in the
> >> compiler, its usage needs to be protected with CONFIG_ARCH_SUPPORTS_INT128.
> >>
> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >> Cc: Yury Norov <yury.norov@xxxxxxxxx>
> >> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> >> Cc: Arnd Bergmann <arnd@xxxxxxxx>>
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: linux-arch@xxxxxxxxxxxxxxx
> >
> > For the patches:
> >
> > Reviewed-by: Yury Norov <yury.norov@xxxxxxxxx>
>
> Thanks Yury.
>
> >
> > This series doesn't include a real use-case for the new macros. Do you
> > have some?
> > I can take it via my branch, but I need at least one use-case to not
> > merge dead code.
>
> I have recently posted the following patch for arm64 platform although
> most of the subsequent work is still in progress. But for now there
> are some corresponding tests for this new GENMASK_U128() ABI as well.
> Hence it will be really great to have these two patches merged first.
> Thank you.
>
> https://lore.kernel.org/all/20240801054436.612024-1-anshuman.khandual@xxxxxxx/
If you're going to merge the above patch in 6.12, you'd normally send
it together with GENMASK_U128 preparation series, get an ACK from me
and Rasmus for bitops part and move through arm64 tree.
Whatever, I've merged it in bitmap-for-next for testing. Please keep
me posted for any following patches.
Thanks,
Yury