Re: [PATCH net 2/6] net: dsa: vsc73xx: pass value in phy_write operation

[Linus Walleij]

On Fri, Aug 2, 2024 at 10:04 AM Pawel Dembicki <paweldembicki@xxxxxxxxx> wrote:

> In the 'vsc73xx_phy_write' function, the register value is missing,
> and the phy write operation always sends zeros.
>
> This commit passes the value variable into the proper register.
>
> Fixes: 975ae7c69d51 ("net: phy: vitesse: Add support for VSC73xx")
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>

It makes perfect sense and I have no idea how I managed
to write this bad code or why it worked so far.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij