Re: [PATCH net-next v3 3/3] net: stmmac: Add PCI driver support for BCM8958x

From: Andrew Lunn
Date: Fri Aug 02 2024 - 19:08:28 EST


> Management of integrated ethernet switch on this SoC is not handled by
> the PCIe interface.

MDIO? SPI? I2C?

> +#define XGMAC_PCIE_MISC_MII_CTRL 0x4
> +#define XGMAC_PCIE_MISC_MII_CTRL_VALUE 0x7

Could you replace these magic values with actual definitions. What
does 7 mean?

> +#define XGMAC_PCIE_MISC_PCIESS_CTRL 0x8
> +#define XGMAC_PCIE_MISC_PCIESS_CTRL_VALUE 0x200

> +static int num_instances;

> + /* This device is directly attached to the switch chip internal to the
> + * SoC using XGMII interface. Since no MDIO is present, register
> + * fixed-link software_node to create phylink.
> + */
> + if (num_instances == 0) {
> + ret = software_node_register_node_group(fixed_link_node_group);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "%s: failed to register software node\n",
> + __func__);
> + return ret;
> + }
> + }
> + num_instances++;

So all the instances of the MAC share one fixed link? That is pretty
unusual. In DT, each would have its own. Have you reviewed the
implications of this?

Andrew