Huacai!
On Tue, Jul 30 2024 at 16:51, Huacai Chen wrote:
On Fri, Jul 26, 2024 at 11:12 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:Yes. It's documented.
Do you mean even if there is only one statement in the if condition,+ while (true) {See bracket rules.
+ vector = csr_read64(LOONGARCH_CSR_IRR);
+ if (vector & IRR_INVALID_MASK)
+ break;
+
+ vector &= IRR_VECTOR_MASK;
+
+ d = this_cpu_read(irq_map[vector]);
+ if (d)
+ generic_handle_irq_desc(d);
+ else {
we still need to do like this?
if (xxx) {
yyy;
} else {
zzz;
}
Why adding it first?OK, thanks. But it is better to split the conversion to another patch+ msi_domain = pci_msi_create_irq_domain(pch_msi_handle[0],Please don't do that. Convert this to use per device MSI domains.
+ &pch_msi_domain_info_v2, parent);
(so we can convert both V1 and V2).
This can be done per interrupt chip. See the conversion series for
ARM[64]:
https://lore.kernel.org/r/20240623142137.448898081@xxxxxxxxxxxxx
Thanks,
tglx