Re: [PATCH] bus: ti-sysc: Use of_property_present()

From: Roger Quadros
Date: Sat Aug 03 2024 - 10:56:39 EST




On 31/07/2024 22:12, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_get_property(). This is part of a larger effort to remove callers
> of of_get_property() and similar functions. of_get_property() leaks
> the DT property data pointer which is a problem for dynamically
> allocated nodes which may be freed.
>
> The code was also incorrectly assigning the return value to a 'struct
> property' pointer. It didn't matter as "prop" was never dereferenced.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Reviewed by: Roger Quadros <rogerq@xxxxxxxxxx>