Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller

From: Rob Herring (Arm)
Date: Sun Aug 04 2024 - 03:23:53 EST



On Sun, 04 Aug 2024 14:38:32 +0800, zhenghaowei@xxxxxxxxxxx wrote:
> From: Haowei Zheng <zhenghaowei@xxxxxxxxxxx>
>
> Add Loongson UART controller binding with DT schema format using
> json-schema.
>
> Signed-off-by: Haowei Zheng <zhenghaowei@xxxxxxxxxxx>
> ---
> .../bindings/serial/loongson,ls7a-uart.yaml | 74 +++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: fractional-division: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: rts-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: dtr-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: cts-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.yaml: dsr-invert: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: reg: [[0, 534774240], [0, 16]] is too long
from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/loongson,ls7a-uart.example.dtb: serial@1fe001e0: Unevaluated properties are not allowed ('clock-frequency', 'reg' were unexpected)
from schema $id: http://devicetree.org/schemas/loongson,ls7a-uart.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240804063834.70022-1-zhenghaowei@xxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.