RE: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page_fini()

[Danielle Ratson]

> From: Yue Haibing <yuehaibing@xxxxxxxxxx>
> Sent: Saturday, 3 August 2024 14:22
> To: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Danielle Ratson <danieller@xxxxxxxxxx>;
> yuehaibing@xxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration
> ethtool_cmis_page_fini()
> 
> ethtool_cmis_page_fini() is declared but never implemented.
> 
> Signed-off-by: Yue Haibing <yuehaibing@xxxxxxxxxx>
> ---
>  net/ethtool/cmis.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h index
> e71cc3e1b7eb..3e7c293af78c 100644
> --- a/net/ethtool/cmis.h
> +++ b/net/ethtool/cmis.h
> @@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8
> cmis_rev, u8 *flags);
> 
>  void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
>  			    u8 page, u32 offset, u32 length); -void
> ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
> 
>  struct ethtool_cmis_cdb *
>  ethtool_cmis_cdb_init(struct net_device *dev,
> --
> 2.34.1
> 

Reviewed-by: Danielle Ratson <danieller@xxxxxxxxxx>

Thanks!