Re: [PATCH v2] wifi: b43: Constify struct lpphy_tx_gain_table_entry
From: Michael Büsch
Date: Sun Aug 04 2024 - 04:40:42 EST
On Sun, 4 Aug 2024 08:32:44 +0200
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
> 'struct lpphy_tx_gain_table_entry' are not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 16481 6232 0 22713 58b9 drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> After:
> =====
> text data bss dec hex filename
> 22305 395 0 22700 58ac drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested-only.
>
> lpphy_write_gain_table() and lpphy_write_gain_table_bulk() could also be
> made static and removed from tables_lpphy.h, but without knowing the reason
> why it is done this way, I've preferred to leave it as-is.
>
> Changes in v2:
> - remove unrelated and un-needed constification [Michael Büsch]
> - update numbers in the commit log
Acked-By: Michael Büsch <m@xxxxxxx>
--
Michael Büsch
https://bues.ch/
Attachment:
pgpQAc9UvobyF.pgp
Description: OpenPGP digital signature