Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is enabled

From: Shengyu Qu
Date: Sun Aug 04 2024 - 08:18:09 EST


You are right. I'm thinking about changing the code like this:

#ifdef CONFIG_NET_MEDIATEK_SOC_WED
if (mtk_wed_device_active(&dev->mt76.mmio.wed)) {
if (is_mt7915(&dev->mt76) ||
!mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY),
0, 0, 0);
else
ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(SET),
MCU_WA_PARAM_WED_VERSION,
dev->mt76.mmio.wed.rev_id, 0);
if (ret)
return ret;
}
#endif

Do you think this is ok?

Best regards,
Shengyu

在 2024/8/4 17:56, Kalle Valo 写道:
Shengyu Qu <wiagn233@xxxxxxxxxxx> writes:

This error report is a false warning. "struct mtk_wed_device" needs
"CONFIG_NET_MEDIATEK_SOC_WED" to be defined.

I didn't investigate anything but based on your description that sounds
wrong. The code should should not be compiled if it depends on
CONFIG_NET_MEDIATEK_SOC_WED but that's not set. We have zero rule for
compilation errors or warnings.

Attachment: OpenPGP_0xE3520CC91929C8E7.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature