Re: [PATCH] mm/z3fold: Add __percpu annotation to *unbuddied pointer in struct z3fold_pool

[Miaohe Lin]

On 2024/7/30 20:34, Uros Bizjak wrote:
> Compiling z3fold.c results in several sparse warnings:
> 
> z3fold.c:797:21: warning: incorrect type in initializer (different address spaces)
> z3fold.c:797:21:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:797:21:    got struct list_head *
> z3fold.c:852:37: warning: incorrect type in initializer (different address spaces)
> z3fold.c:852:37:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:852:37:    got struct list_head *
> z3fold.c:924:25: warning: incorrect type in assignment (different address spaces)
> z3fold.c:924:25:    expected struct list_head *unbuddied
> z3fold.c:924:25:    got void [noderef] __percpu *_res
> z3fold.c:930:33: warning: incorrect type in initializer (different address spaces)
> z3fold.c:930:33:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:930:33:    got struct list_head *
> z3fold.c:949:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:949:25:    expected void [noderef] __percpu *__pdata
> z3fold.c:949:25:    got struct list_head *unbuddied
> z3fold.c:979:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:979:25:    expected void [noderef] __percpu *__pdata
> z3fold.c:979:25:    got struct list_head *unbuddied
> 
> Add __percpu annotation to *unbuddied pointer to fix these warnings.
> 
> Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> Cc: Vitaly Wool <vitaly.wool@xxxxxxxxxxxx>
> Cc: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Thanks.
.