Re: [PATCH tip/sched/core] sched/fair: Make balance_fair() test sched_fair_runnable() instead of rq->nr_running
From: Tejun Heo
Date: Mon Aug 05 2024 - 14:09:19 EST
Hello,
On Mon, Aug 05, 2024 at 08:51:05AM +0530, K Prateek Nayak wrote:
...
> When does this happen exactly? throttle_cfs_rq() calls sub_nr_running()
> negating the "h_nr_running" of the throttled entity from the
> rq->nr_running. Even deadline entities on being throttled dequeue the
> entity (or don't enqueue them at all in enqueue_dl_entity()) and would
> have the correct "rq->nr_running". Could you please highlight the path
> that might hit this scenario?
I just missed the sub_nr_running() call. No wonder I couldn't see behavior
difference. I'll redo the patch description.
Thanks.
--
tejun