Re: [PATCH net v2] net: dsa: microchip: Fix Wake-on-LAN check to not return an error

From: Florian Fainelli
Date: Mon Aug 05 2024 - 19:55:17 EST


On 8/5/24 16:52, Tristram.Ha@xxxxxxxxxxxxx wrote:
From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>

The wol variable in ksz_port_set_mac_address() is declared with random
data, but the code in ksz_get_wol call may not be executed so the
WAKE_MAGIC check may be invalid resulting in an error message when
setting a MAC address after starting the DSA driver.

Fixes: 3b454b6390c3 ("net: dsa: microchip: ksz9477: Add Wake on Magic Packet support")
Signed-off-by: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>
Reviewed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian