Re: [PATCH REPOST] lib/build_OID_registry: do not embed full $0

[Masahiro Yamada]

On Mon, Aug 5, 2024 at 6:13 PM Giuliano Procida <gprocida@xxxxxxxxxx> wrote:
>
> Please ignore this. I see other people have already posted different
> fixes achieving much the same goal.
>
> Though my change was much simpler!


True.

There were suggestions to replace this with a fixed string:


https://lore.kernel.org/linux-kbuild/CAK7LNASa-KedA_CTww6unckAGkJCQTctdbk0d-MUsN7wQpM=kQ@xxxxxxxxxxxxxx/
https://lore.kernel.org/linux-kbuild/ZfP1xdcYlUawm3uV@xxxxxxxxxxxxxxxx/



A needlessly complex patch was applied, unfortunately.










>
> On Mon, 5 Aug 2024 at 10:09, Giuliano Procida <gprocida@xxxxxxxxxx> wrote:
> >
> > Using $0 makes the output of this file sensitive to the Linux build
> > directory path. This is problematic for reproducible builds as it can
> > affect vmlinux's .debug_lines' section and vmlinux's build ID.
> >
> > Signed-off-by: Giuliano Procida <gprocida@xxxxxxxxxx>
> > ---
> >  lib/build_OID_registry | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/build_OID_registry b/lib/build_OID_registry
> > index d7fc32ea8ac2..06f242202036 100755
> > --- a/lib/build_OID_registry
> > +++ b/lib/build_OID_registry
> > @@ -35,7 +35,7 @@ close IN_FILE || die;
> >  #
> >  open C_FILE, ">$ARGV[1]" or die;
> >  print C_FILE "/*\n";
> > -print C_FILE " * Automatically generated by ", $0, ".  Do not edit\n";
> > +print C_FILE " * Automatically generated by build_OID_registry.  Do not edit\n";
> >  print C_FILE " */\n";
> >




--
Best Regards
Masahiro Yamada