Re: [PATCH v2 1/1] iio: light: apds9960: Add proximity and gesture offset calibration

[Abhash jha]

On Sat, Aug 3, 2024 at 7:28 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Thu,  1 Aug 2024 20:08:57 +0530
> Abhash Jha <abhashkumarjha123@xxxxxxxxx> wrote:
>
> > Proximity and gesture offset registers perform offset correction to
> > improve cross-talk performance. Added `calibbias` to the proximity
> > and gesture channels.
> > Provided facility to set calibbias based on the channel number.
> >
> > Signed-off-by: Abhash Jha <abhashkumarjha123@xxxxxxxxx>
>
> I nearly applied this with tweaks, but I think there are enough improvements
> that can be made to make it worth bouncing back to you one more time
>
> Thanks,
>
> Jonathan

Hi Jonathan,
I hope I understood what  you were trying to say correctly, I made a 2D array
for the registers and then modified the set_calibbias function accordingly.
Here is the link to the patch v3 :
https://lore.kernel.org/linux-iio/20240804134212.51682-1-abhashkumarjha123@xxxxxxxxx/T/#t
Do tell me if there is something else that needs to be changed.

Thanks,
Abhash