Re: [syzbot] [can?] WARNING: refcount bug in j1939_xtp_rx_cts
From: Hillf Danton
Date: Tue Aug 06 2024 - 06:51:36 EST
On Mon, 05 Aug 2024 14:29:36 -0700
> syzbot found the following issue on:
>
> HEAD commit: 743ff02152bc ethtool: Don't check for NULL info in prepare..
> git tree: net-next
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=162bd19d980000
#syz test net-next 743ff02152bc
--- x/net/can/j1939/transport.c
+++ y/net/can/j1939/transport.c
@@ -1505,6 +1505,7 @@ static struct j1939_session *j1939_sessi
session->state = J1939_SESSION_NEW;
skb_queue_head_init(&session->skb_queue);
+ skb_get(skb);
skb_queue_tail(&session->skb_queue, skb);
skcb = j1939_skb_to_cb(skb);
--