Hi Pierre,
On 8/1/2024 1:07 AM, Pierre-Louis Bossart wrote:
ACK.
+static inline int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,usually fallback functions return 0, is the error code intentional?
+ struct snd_soc_jack *jack)
+{
+ return -ENODEV;
+}
+
+static inline int snd_soc_usb_disable_offload_jack(struct snd_soc_component *component)
+{
+ return -ENODEV;
+}
No, will remove.
+int snd_soc_usb_setup_offload_jack(struct snd_soc_component *component,do we need the reference to Playback?
+ struct snd_soc_jack *jack)
+{
+ int ret;
+
+ ret = snd_soc_card_jack_new(component->card, "USB Offload Playback Jack",
Not as of now, but I think we discussed in the past that maybe depending on if playback and capture is supported, we can notify SND_JACK_HEADSET? That is something I will need to change depending on how we want to handle the comments on patch#9+ SND_JACK_HEADPHONE, jack);wondering if there would be any merit in defining a new type of jack,
e.g. SND_JACK_USB since here the purpose is to notify that there's a USB
device connected. The type of device does not really matter, does it?