Re: [PATCH v8 1/3] firmware: ti_sci: Introduce Power Management Ops

From: Nishanth Menon
Date: Tue Aug 06 2024 - 11:40:43 EST


On 21:54-20240801, Markus Schneider-Pargmann wrote:
> From: Dave Gerlach <d-gerlach@xxxxxx>
[...]

> + pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;

did you miss populating the rest of the pm ops?
See https://lore.kernel.org/all/202408031302.28NpPykP-lkp@xxxxxxxxx/

It might be better to introduce the APIs one at a time?

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D