Re: [PATCH 2/2] dt-bindings: iio: asahi-kasei,ak8975: drop incorrect AK09116 compatible

From: Jonathan Cameron
Date: Tue Aug 06 2024 - 12:11:28 EST


On Tue, 6 Aug 2024 17:02:49 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Tue, Aug 06, 2024 at 07:30:16AM +0200, Krzysztof Kozlowski wrote:
> > All compatibles in this binding without prefixes were deprecated, so
> > adding a new deprecated one after some time is not allowed, because it
> > defies the core logic of deprecating things.
> >
> > Drop the AK09916 vendorless compatible.
> >
> > Fixes: 76e28aa97fa0 ("iio: magnetometer: ak8975: add AK09116 support")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >
> > ---
> >
> > Offending commit did not even bother to Cc devicetree mailing list and
> > DT maintainers... Lovely. Let's ignore submitting patches and
> > maintainers just to sneak my important patch into the kernel.
>
> :/
>
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Let's assume mistake rather than malicious.
I should have noticed this :(

Anyhow, applied both patches to the togreg branch of iio.git.
Initially pushed out as testing for 0-day to take a look at other
stuff that's queued up.

Jonathan

>
> Thanks,
> Conor.
>
> > ---
> > .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > index 9790f75fc669..fe5145d3b73c 100644
> > --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> > @@ -23,7 +23,6 @@ properties:
> > - ak8963
> > - ak09911
> > - ak09912
> > - - ak09916
> > deprecated: true
> >
> > reg:
> > --
> > 2.43.0
> >