Re: [PATCH -next] spmi: pmic-arb: Add check for return value of platform_get_resource_byname

[Stephen Boyd]

Quoting cuigaosheng (2024-08-06 05:06:40)
> Thanks for your time.

Please don't top post.

> 
> I've made and submitted a patch v2, and I think the right fixes tag is 
> as follows:
> 
> Fixes: 39ae93e3a31d ("spmi: Add MSM PMIC Arbiter SPMI controller")

Don't think so. If the resource isn't there, the pointer returned is
NULL, devm_ioremap_resource() would bail out early if the resource is
NULL and return an error. I suggested that fixes tag because it removed
the size check. But now I see that resource_size() on a NULL pointer
would blow up. So the real fixes tag is

Fixes: 987a9f128b8a ("spmi: pmic-arb: Support more than 128 peripherals")

because that introduced the call to resource_size() on a potentially
NULL pointer.