Re: [PATCH net-next v2] net: tuntap: add ioctl() TUNGETQUEUEINDEX to fetch queue index

From: Jakub Kicinski
Date: Tue Aug 06 2024 - 15:00:47 EST


On Thu, 1 Aug 2024 21:49:21 +0800 Randy Li wrote:
> + if(put_user(tfile->queue_index, (unsigned int __user*)argp))

Checkpatch has some legitimate complains about this line:

ERROR: "(foo*)" should be "(foo *)"
#58: FILE: drivers/net/tun.c:3160:
+ if(put_user(tfile->queue_index, (unsigned int __user*)argp))

ERROR: space required before the open parenthesis '('
#58: FILE: drivers/net/tun.c:3160:
+ if(put_user(tfile->queue_index, (unsigned int __user*)argp))


Assuming Willem is okay with the feature, please add appropriate tests
in tools/testing/selftests/net/tap.c
--
pw-bot: cr