Re: [PATCH 0/2] KVM: Protect vCPU's PID with a rwlock
From: Oliver Upton
Date: Tue Aug 06 2024 - 18:59:39 EST
On Fri, Aug 02, 2024 at 01:01:34PM -0700, Sean Christopherson wrote:
> Protect vcpu->pid with a rwlock instead of RCU, so that running a vCPU
> with a different task doesn't require a full RCU synchronization, which
> can introduce a non-trivial amount of jitter, especially on large systems.
>
> I've had this mini-series sitting around for ~2 years, pretty much as-is.
> I could have sworn past me thought there was a flaw in using a rwlock, and
> so I never posted it, but for the life of me I can't think of any issues.
>
> Extra eyeballs would be much appreciated.
Besides the nitpicks:
Acked-by: Oliver Upton <oliver.upton@xxxxxxxxx>
--
Thanks,
Oliver