Re: [PATCH 3/3] arm64: dts: amlogic: add C3 AW419 board

[Xianwei Zhao]

Hi Krzysztof,
    Thanks for your reply.

On 2024/8/6 21:14, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 06/08/2024 12:27, Xianwei Zhao via B4 Relay wrote:
> > From: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> >
> > Add Amlogic C3 C308L AW419 board.
> >
> > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/amlogic/Makefile               |   1 +
> >   .../boot/dts/amlogic/amlogic-c3-c308l-aw419.dts    | 278 +++++++++++++++++++++
> >   2 files changed, 279 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> > index 29417f04f886..2fbda8419c65 100644
> > --- a/arch/arm64/boot/dts/amlogic/Makefile
> > +++ b/arch/arm64/boot/dts/amlogic/Makefile
> > @@ -2,6 +2,7 @@
> >   dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb
> >   dtb-$(CONFIG_ARCH_MESON) += amlogic-a5-a113x2-av400.dtb
> >   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
> > +dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c308l-aw419.dtb
> >   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
> >   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
> >   dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb
> > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts b/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts
> > new file mode 100644
> > index 000000000000..d28fd2a1acf0
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3-c308l-aw419.dts
> > @@ -0,0 +1,278 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "amlogic-c3.dtsi"
> > +
> > +/ {
> > +     model = "Amlogic C308l aw419 Development Board";
> > +     compatible = "amlogic,aw419", "amlogic,c3";
>
> Where are the bindings? Why do you add bindings without boards? Or
> boards without bindings?
The bindings of board aw419 was submitted with board aw409.
The commit number is cb3f4e8cacfa7b32ed8b9dff1282c0d4aaf42e88.
> Best regards,
> Krzysztof