Re: [PATCH v3 1/4] x86/split_lock: Move Split and Bus lock code to a dedicated file

[Ravi Bangoria]

>> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
>> index 5857a0f5d514..9f74e0011f01 100644
>> --- a/arch/x86/kernel/cpu/Makefile
>> +++ b/arch/x86/kernel/cpu/Makefile
>> @@ -27,6 +27,7 @@ obj-y			+= aperfmperf.o
>>  obj-y			+= cpuid-deps.o
>>  obj-y			+= umwait.o
>>  obj-y 			+= capflags.o powerflags.o
>> +obj-y			+= bus_lock.o
> 
> Since the whole file is protected by a "#if defined", why not just use
> that here and conditionally build it?
> 
> You could also create a Kconfig that is set when CPU_SUP_INTEL is
> selected and, later when CPU_SUP_AMD is selected, and use that
> (CONFIG_X86_BUS_LOCK or such).

New CONFIG seems like a better option. Will respin with that.

Thanks for the review,
Ravi