Re: [PATCH v2 0/7] can: m_can: Fix polling and other issues

[Matthias Schiffer]

On Mon, 2024-08-05 at 20:30 +0200, Markus Schneider-Pargmann wrote:
> Hi everyone,
> 
> these are a number of fixes for m_can that fix polling mode and some
> other issues that I saw while working on the code.
> 
> Any testing and review is appreciated.

Hi Markus,

thanks for the series. I gave it a quick spin on the interrupt-less AM62x CAN, and found that it
fixes the deadlock I reported and makes CAN usable again.

For the whole series:

Tested-by: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxxxxx>




> 
> Base
> ----
> v6.11-rc1
> 
> Changes in v2
> -------------
>  - Fixed one multiline comment
>  - Rebased to v6.11-rc1
> 
> Previous versions
> -----------------
>  v1: https://lore.kernel.org/lkml/20240726195944.2414812-1-msp@xxxxxxxxxxxx/
> 
> Best,
> Markus
> 
> Markus Schneider-Pargmann (7):
>   can: m_can: Reset coalescing during suspend/resume
>   can: m_can: Remove coalesing disable in isr during suspend
>   can: m_can: Remove m_can_rx_peripheral indirection
>   can: m_can: Do not cancel timer from within timer
>   can: m_can: disable_all_interrupts, not clear active_interrupts
>   can: m_can: Reset cached active_interrupts on start
>   can: m_can: Limit coalescing to peripheral instances
> 
>  drivers/net/can/m_can/m_can.c | 111 ++++++++++++++++++++--------------
>  1 file changed, 66 insertions(+), 45 deletions(-)
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/