Re: [PATCH] sched/deadline: Fix imbalanced task reference

[Juri Lelli]

Hi,

On 07/08/24 16:30, Zhang Qiao wrote:
> When starting a deadline inactive_timer, the task_struct refs will
> be incremented only if dl_server is not set. But when canceling the
> inactive_timer, the task refs will be decremented whether dl_server is
> set or not, leading to a task reference imbalance issue.
> 
> This patch fixes the imbalanced reference by adding a '!dl_server()'
> checker before calling put_task_struct().
> 
> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
> Signed-off-by: Zhang Qiao <zhangqiao22@xxxxxxxxxx>

Isn't this equivalent to Wander's patch below?

https://lore.kernel.org/lkml/20240724142253.27145-3-wander@xxxxxxxxxx/

Thanks,
Juri