Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header
From: Oleksij Rempel
Date: Wed Aug 07 2024 - 05:14:11 EST
Hi Arnd,
Thank you for your patch.
I acked already other one:
https://lore.kernel.org/all/20240807071538.569784-1-guanjun@xxxxxxxxxxxxxxxxx/
On Wed, Aug 07, 2024 at 09:54:22AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
>
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
> 755 | if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
> | ^~~~~~~~~
>
> Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |