Re: [PATCH 1/2] serial: 8250_platform: remove ACPI_PTR() annotation
From: Sunil V L
Date: Wed Aug 07 2024 - 05:24:39 EST
On Wed, Aug 07, 2024 at 09:57:43AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The acpi_platform_serial_table[] array is defined globally without
> an #ifdef check for CONFIG_ACPI, so ACPI_PTR() makes no sense
> here:
>
> drivers/tty/serial/8250/8250_platform.c:271:36: error: 'acpi_platform_serial_table' defined but not used [-Werror=unused-const-variable=]
> 271 | static const struct acpi_device_id acpi_platform_serial_table[] = {
>
> Fixes: d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c
> index 306b488aa996..c9ef988d58b3 100644
> --- a/drivers/tty/serial/8250/8250_platform.c
> +++ b/drivers/tty/serial/8250/8250_platform.c
> @@ -281,7 +281,7 @@ static struct platform_driver serial8250_isa_driver = {
> .resume = serial8250_resume,
> .driver = {
> .name = "serial8250",
> - .acpi_match_table = ACPI_PTR(acpi_platform_serial_table),
> + .acpi_match_table = acpi_platform_serial_table,
Reviewed-by: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>
Thanks!
Sunil