Re: [PATCH v3 4/5] arm64: dts: ti: k3-j721e*: Add bootph-* properties

From: Manorit Chawdhry
Date: Wed Aug 07 2024 - 05:49:45 EST


Hi Neha,

On 14:54-20240807, Neha Malcom Francis wrote:
> Hi Manorit,
>
> On 30/07/24 15:23, Manorit Chawdhry wrote:
> > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > utilise them.
> >
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
> > ---
> > .../arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 20 ++++++++++++++++++++
> > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 2 ++
> > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 9 +++++++++
> > arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 18 ++++++++++++++++++
> > arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi | 5 +++++
> > 5 files changed, 54 insertions(+)
> >
[..]
> > @@ -440,6 +444,7 @@ &hbmc {
> > flash@0,0 {
> > compatible = "cypress,hyperflash", "cfi-flash";
> > reg = <0x00 0x00 0x4000000>;
> > + bootph-all;
> > partitions {
> > compatible = "fixed-partitions";
> >
>
> Sanity boot tested on J721E-SK after porting to U-Boot. Thanks for the
> patch, along with the reviews made by Udit (although one additional mention:
> IIRC, OSPI partitions are cosmetic for the U-Boot driver, but better to add
> bootph even if it's cosmetic in case the driver changes the next day), with
> those addressed:
>
> Reviewed-by: Neha Malcom Francis <n-francis@xxxxxx>

Would be following up on those comments. Thanks for reviewing and
testing!

Regards,
Manorit

>
> --
> Thanking You
> Neha Malcom Francis