Re: [PATCH net-next] eventpoll: Don't re-zero eventpoll fields

[Jan Kara]

On Wed 07-08-24 10:52:31, Joe Damato wrote:
> Remove redundant and unnecessary code.
> 
> ep_alloc uses kzalloc to create struct eventpoll, so there is no need to
> set fields to defaults of 0. This was accidentally introduced in commit
> 85455c795c07 ("eventpoll: support busy poll per epoll instance") and
> expanded on in follow-up commits.
> 
> Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx>
> Reviewed-by: Martin Karsten <mkarsten@xxxxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/eventpoll.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index f53ca4f7fced..6c0a1e9715ea 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -2200,11 +2200,6 @@ static int do_epoll_create(int flags)
>  		error = PTR_ERR(file);
>  		goto out_free_fd;
>  	}
> -#ifdef CONFIG_NET_RX_BUSY_POLL
> -	ep->busy_poll_usecs = 0;
> -	ep->busy_poll_budget = 0;
> -	ep->prefer_busy_poll = false;
> -#endif
>  	ep->file = file;
>  	fd_install(fd, file);
>  	return fd;
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR