Re: [PATCH net-next] net: sungem_phy: Constify struct mii_phy_def
From: Andrew Lunn
Date: Wed Aug 07 2024 - 09:58:08 EST
On Wed, Aug 07, 2024 at 02:22:26PM +0200, Christophe JAILLET wrote:
> 'struct mii_phy_def' are not modified in this driver.
>
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
>
> While at it fix the checkpatch warning related to this patch (some missing
> newlines and spaces around *)
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> 27709 928 0 28637 6fdd drivers/net/sungem_phy.o
>
> After:
> =====
> text data bss dec hex filename
> 28157 476 0 28633 6fd9 drivers/net/sungem_phy.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew