Re: [PATCH v3 03/17] wifi: cc33xx: Add sdio.c, io.c, io.h

[Nemanov, Michael]

On 8/7/2024 10:12 AM, Krzysztof Kozlowski wrote:



> > +static const struct of_device_id cc33xx_sdio_of_match_table[] = {
> > +	{ .compatible = "ti,cc3300", .data = &cc33xx_data },
> > +	{ .compatible = "ti,cc3301", .data = &cc33xx_data },
> > +	{ .compatible = "ti,cc3350", .data = &cc33xx_data },
> > +	{ .compatible = "ti,cc3351", .data = &cc33xx_data },
> > +	{ }
> > +};
>
>
> Eh? What happened here? So devices are compatibles thus make them
> compatible in the bindings.

I thought this is the right way to do it (originally taken from [1]).
How can I solve it via DT bindings?

> > +
> > +module_param(dump, bool, 0600);
> > +MODULE_PARM_DESC(dump, "Enable sdio read/write dumps.");
>
> This should be rather debug interface, not module param.

Meaning debugFS?

Thanks and regards,
Michael.


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/ti/wlcore/sdio.c#n204