Re: [PATCH 1/1] selinux: add the processing of the failure of avc_add_xperms_decision()

[Paul Moore]

On Aug  7, 2024 thunder.leizhen@xxxxxxxxxxxxxxx wrote:
> 
> When avc_add_xperms_decision() fails, the information recorded by the new
> avc node is incomplete. In this case, the new avc node should be released
> instead of replacing the old avc node.
> 
> Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
> Suggested-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> Acked-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> ---
>  security/selinux/avc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks, this looks good to me.  I'm going to merge this into
selinux/stable-6.11 with the idea of sending it, and your other
patch, up to Linus tomorrow, or potentially next week.

Thanks for your help!

--
paul-moore.com