Re: [PATCH] clk: renesas: fix r9a09g057_cpg_info link error
From: Stephen Boyd
Date: Wed Aug 07 2024 - 16:52:36 EST
Quoting Arnd Bergmann (2024-08-07 00:56:58)
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The rzv2g-cpg.c driver unconditionally links into the r9a09g057
> one, but that may be disabled:
>
> aarch64-linux-ld: drivers/clk/renesas/rzv2h-cpg.o:(.rodata+0x440): undefined reference to `r9a09g057_cpg_info'
>
> Use the same approach here as with the rzg2l variant, using an #ifdef
> around tha data.
>
> I think both drivers would be better off doing the abstraction the other
> way round, with the platform_driver structure defined in the most specific
> file and the common bits as a library that exports common functions.
> Changing it that way would require a larger rework of course.
>
> Fixes: 42b54d52ecb7 ("clk: renesas: Add RZ/V2H(P) CPG driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
This is https://lore.kernel.org/r/20240805095842.277792-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx