RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform
From: Potthuri, Sai Krishna
Date: Thu Aug 08 2024 - 01:53:58 EST
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, August 5, 2024 3:38 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx>; Linus Walleij
> <linus.walleij@xxxxxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>; Rob
> Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Buddhabhatti, Jay <jay.buddhabhatti@xxxxxxx>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@xxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>
> Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
> platform
>
> On 01/08/2024 14:00, Sai Krishna Potthuri wrote:
> > Add Xilinx Versal compatible string and corresponding groups, function
> > and pins properties to support pin controller features on Versal platform.
> >
> > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@xxxxxxx>
> > ---
> > .../bindings/pinctrl/xlnx,versal-pinctrl.yaml | 398
> > ++++++++++++++++++
> > 1 file changed, 398 insertions(+)
> > + bias-pull-up: true
> > +
> > + bias-pull-down: true
> > +
> > + bias-disable: true
> > +
> > + input-schmitt-enable: true
> > +
> > + input-schmitt-disable: true
> > +
> > + bias-high-impedance: true
> > +
> > + low-power-enable: true
> > +
> > + low-power-disable: true
>
> Why do you need to copy all of these? Just switch to unevaluatedProperties.
I tried with "unevaluatedProperties: false", it worked but by adding this all the
properties in the pincfg-node.yaml become valid for this platform which is not
true. Not all the properties in the pincfg-node.yaml are supported in this platform.
So, is there any other way of representing this?
Regards
Sai Krishna