Re: [PATCH v4 8/8] reset: mchp: sparx5: set the dev member of the reset controller

From: Steen Hegelund
Date: Thu Aug 08 2024 - 04:22:45 EST


Hi Herve,

On Mon, 2024-08-05 at 12:17 +0200, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> From: Clément Léger <clement.leger@xxxxxxxxxxx>
>
> In order to guarantee the device will not be deleted by the reset
> controller consumer, set the dev member of the reset controller.
>
> Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> ---
>  drivers/reset/reset-microchip-sparx5.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-microchip-sparx5.c
> b/drivers/reset/reset-microchip-sparx5.c
> index c4fe65291a43..1ef2aa1602e3 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -117,6 +117,7 @@ static int mchp_sparx5_reset_probe(struct
> platform_device *pdev)
>                 return err;
>
>         ctx->rcdev.owner = THIS_MODULE;
> +       ctx->rcdev.dev = &pdev->dev;
>         ctx->rcdev.nr_resets = 1;
>         ctx->rcdev.ops = &sparx5_reset_ops;
>         ctx->rcdev.of_node = dn;
> --
> 2.45.0
>

Looks good to me.

Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>

BR
Steen