Re: [PATCH net-next v3 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet

[Pieter]

On Wed 7 Aug 2024 at 05:41, <Arun.Ramadoss@xxxxxxxxxxxxx> wrote:
>
> Hi Pieter,
>
> On Tue, 2024-08-06 at 15:25 +0200, vtpieter@xxxxxxxxx wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx>
> >
> > The KSZ87xx switches have 32 entries and not 8. This fixes -ENOSPC
> > errors from ksz8_add_sta_mac when configured as a bridge.
> >
> > Add a new ksz87xx_dev_ops structure to be able to use the
> > ksz_r_mib_stat64 pointer for this family; this corrects a wrong
> > mib->counters cast to ksz88xx_stats_raw. This fixes iproute2
> > statistics.
> >
> > Signed-off-by: Pieter Van Trappen <pieter.van.trappen@xxxxxxx>
> > ---
> >
> >  static void ksz9477_phylink_mac_link_up(struct phylink_config
> > *config,
> >                                         struct phy_device *phydev,
> >                                         unsigned int mode,
> > @@ -1262,12 +1297,12 @@ const struct ksz_chip_data ksz_switch_chips[]
> > = {
> >                 .dev_name = "KSZ8795",
> >                 .num_vlans = 4096,
> >                 .num_alus = 0,
> > -               .num_statics = 8,
> > +               .num_statics = 32,
> >                 .cpu_ports = 0x10,      /* can be configured as cpu
> > port */
> >                 .port_cnt = 5,          /* total cpu and user ports
> > */
> >                 .num_tx_queues = 4,
> >                 .num_ipms = 4,
> > -               .ops = &ksz8_dev_ops,
>
> Why don't we rename ksz8_dev_ops also like KSZ88x3_dev_ops or
> KSZ88xx_dev_ops, since it is now used only by KSZ8863 and KSZ8873
> switches.

Hi Arun, indeed that would make more sense. Will rename to
ksz88x3_dev_ops, consistent with the ksz_is_* function names
in ksz_common.h.

Thanks, Pieter