Re: [PATCH net-next v3 4/5] net: dsa: microchip: add WoL support for KSZ87xx family

[Pieter]

On Wed 7 Aug 2024 at 05:56, <Arun.Ramadoss@xxxxxxxxxxxxx> wrote:
>
> Hi Pieter,
>
>
> >
> > +               if (ksz_is_ksz87xx(dev))
> > +                       ksz_write8(dev, KSZ8795_REG_INT_EN,
> > KSZ8795_INT_PME_MASK);
>
> nitpick:
> Do we need to rename register like KSZ87xx_REG_INT_EN since it is
> common to other switches as well?

Hi Arun, well it's all a bit confusing already I have to admit. There is a
filename ksz8795.c that contains code for ksz88x3 and ksz87xx devices.
Also the tag protocol is named DSA_TAG_PROTO_KSZ8795.

Now it seems from function prefixes and ksz_common.h `is_ksz8`
that in many places `ksz8795` should be replaced by `ksz8` instead.
I don't it's up to me to make this kind of decisions so I went along with
the existing naming convention as much as I could but indeed, this
specific register I will rename to KSZ87xx_REG_INT_EN.

Thanks, Pieter