[PATCH 3/4] fs: remove audit dummy context check
From: Christian Brauner
Date: Thu Aug 08 2024 - 05:15:41 EST
Now that we audit later during lookup_open() we can remove the audit
dummy context check. This simplifies things a lot.
Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
---
fs/namei.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 08eb9a53beb7..96c79dec7184 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3624,16 +3624,6 @@ static struct dentry *lookup_fast_for_open(struct nameidata *nd, int open_flag)
/* Don't bother on an O_EXCL create */
if (open_flag & O_EXCL)
return NULL;
-
- /*
- * FIXME: If auditing is enabled, then we'll have to unlazy to
- * use the dentry. For now, don't do this, since it shifts
- * contention from parent's i_rwsem to its d_lockref spinlock.
- * Reconsider this once dentry refcounting handles heavy
- * contention better.
- */
- if ((nd->flags & LOOKUP_RCU) && !audit_dummy_context())
- return NULL;
}
if (trailing_slashes(nd))
@@ -3687,7 +3677,7 @@ static const char *open_last_lookups(struct nameidata *nd,
bool unlazied;
/* can stay in rcuwalk if not auditing */
- if (dentry && audit_dummy_context())
+ if (dentry)
goto finish_lookup;
unlazied = dentry ? try_to_unlazy_next(nd, dentry) :
try_to_unlazy(nd);
--
2.43.0
--37h7k3p7s7sj3yhb
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
filename="0004-fs-rearrange-general-fastpath-check-now-that-O_CREAT.patch"