RE: [EXTERNAL] Re: [net-next PATCH v10 00/11] Introduce RVU representors

From: Sunil Kovvuri Goutham
Date: Thu Aug 08 2024 - 07:31:03 EST


- Patch 10: Add devlink port support.
>
>I can't bring myself to apply this.
>Jiri do you have an opinion?
>The device is a NPU/SmartNIC/DPU/IPU, it should be very flexible.
>Yet, instead of just implementing the representors like everyone else you do your
>own thing and create separate bus devices.

Can you please elaborate what you mean by "create separate bus devices"

Just to clarify we are not creating separate bus devices for representors perse.
On our HW, there are multiple SRIOV PCI devices.
We are using one of those PCI devices (pci/0002:1c:00.0), to attach required hardware resources to it, for doing packet IO
Between representors and the representees. Once the HW resources (Rx, Tx queues) are attached to it
we are registering multiple netdevs from this ie one rx/tx queue for one representor.
Beyond that there are no other bus devices being created/used.

>Not sure if this breaks anything today, but it certainly subverts the model where
>representors represent bus devices.
>You can't represent all bus devices, because of the obvious cycle.
>